View Single Post
Old 12-18-2006, 04:58 PM   #3
henkvdg
Groupie
henkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of ithenkvdg has read War And Peace ... all of it
 
Posts: 180
Karma: 66830
Join Date: Oct 2006
Device: IREX iLiad, Pocketbook Pro 903
OK

Quote:
Originally Posted by scotty1024
I wondered why I was chasing my tail so vigorously with the highlighter enhancement, then I found this bug...

In SplashOutputDev.cc in method void SplashOutputDev::setFillColor(int r, int g, int b)

Code:
  gray = (GfxColorComp)(0.299 * rgb.r + 0.587 * rgb.g + 0.114 * rgb.g + 0.5);
Should be

Code:
  gray = (GfxColorComp)(0.299 * rgb.r + 0.587 * rgb.g + 0.114 * rgb.b + 0.5);
Building a better iLiad, one Poppler bug at at time.

I've also built a splashModeMono4 into Poppler and I'm testing it to make sure the error dispersion works the way iRex likes it. This will require a new poppler and a new ipdf to use it. The new ipdf won't work with an older poppler since the older poppler doesn't grok splashModeMono4. But an old ipdf will work with the new poppler.
Good work, Scotty !
henkvdg is offline   Reply With Quote