MobileRead Forums - View Single Post

KevinH · Yesterday, 11:55 AM

Just a head's up for those who build their own.

Given all the changes in native nested selectors and CSS 4, Sigil has opted to move to a completely new css parser, moving away from our old CSSTidy derived one. This new css parser is from lexbor.

See https://github.com/lexbor/lexbor

We are using just their css library, statically built. Sigil needed some slight css parser changes that the lexbor developer has agreed to but since those changes modify its abi, we must maintain our changes until such time lexbor is ready to release a new major version. Inside Sigil this code exists inside Sigil/internal/lexbor along side our gumbo version.

Lexbor also has a nice selector implementation we should take a closer look at and an html whatwg spec compliant parser and dom implementation we could move to when and if gumbo gets long in the tooth.

Next our current source code base uses a number of C++ singleton classes which were in desperate need of an overhaul. So each singleton class and surrounding code has been moved to use the Meyers form of the Singleton which should help speed Sigil startup time because of its lazy loading while more safely cleaning up after itself upon exiting Sigil. This change touches a large number of files in Sigil.

Third, I have borrowed code from the hostile Chinese Sigil-Enhanced fork, that should speed up BookBrowser refreshes. Wish they would have contributed that back since they took all our code and never even let us know but ...

Fourth, I have also modified AddExisting to speed up bulk replacement of image files during AddExisting or our DropZone. This time without breaking anything!

So if you do build your own, please start with a fresh build and fresh cmake run to make sure none of the changed files are missed as many new files have been added.

Lastly if you get a chance please test out the single line css reformat and multi-line css reformat and "go to style" in CodeView to make sure I have not broken anything when interfacing their css parser library to our code. It all seems to work for me but more testing is always welcome.

Yesterday, 11:55 AM	#1
KevinH Sigil Developer Posts: 9,840 Karma: 7500000 Join Date: Nov 2009 Device: many	Head's up for those who build their own. Just a head's up for those who build their own. Given all the changes in native nested selectors and CSS 4, Sigil has opted to move to a completely new css parser, moving away from our old CSSTidy derived one. This new css parser is from lexbor. See https://github.com/lexbor/lexbor We are using just their css library, statically built. Sigil needed some slight css parser changes that the lexbor developer has agreed to but since those changes modify its abi, we must maintain our changes until such time lexbor is ready to release a new major version. Inside Sigil this code exists inside Sigil/internal/lexbor along side our gumbo version. Lexbor also has a nice selector implementation we should take a closer look at and an html whatwg spec compliant parser and dom implementation we could move to when and if gumbo gets long in the tooth. Next our current source code base uses a number of C++ singleton classes which were in desperate need of an overhaul. So each singleton class and surrounding code has been moved to use the Meyers form of the Singleton which should help speed Sigil startup time because of its lazy loading while more safely cleaning up after itself upon exiting Sigil. This change touches a large number of files in Sigil. Third, I have borrowed code from the hostile Chinese Sigil-Enhanced fork, that should speed up BookBrowser refreshes. Wish they would have contributed that back since they took all our code and never even let us know but ... Fourth, I have also modified AddExisting to speed up bulk replacement of image files during AddExisting or our DropZone. This time without breaking anything! So if you do build your own, please start with a fresh build and fresh cmake run to make sure none of the changed files are missed as many new files have been added. Lastly if you get a chance please test out the single line css reformat and multi-line css reformat and "go to style" in CodeView to make sure I have not broken anything when interfacing their css parser library to our code. It all seems to work for me but more testing is always welcome. Last edited by KevinH; Yesterday at 12:00 PM.