|
Okay, the whole idea behind needsToUpdateOPF was broken. I have reverted the code in AddExisting to do a full delete of the image resource with immediate updating of the opf before re-adding it with its replacement.
Correct and slower is much better than sometimes incorrect and faster.
We can revisit this in the future by directly writing the new image data to its underlying file with no changes at all to the OPF to re-speed things up. But I want stability now, not more changes that may be broken in some way. There are just too many code paths in that one routine and too many special cases to handle. It should probably be completely rewritten at some point. But right now it should be fully working.
I have pushed this fix to master. So if you build your own, please update it.
(DiapDealer I used deploy so you should be able to grab a build too).
Thank you for your bug report!
|