Quote:
Originally Posted by KevinH
Okay, I have pushed to master a test of the new PreviewFileDialog class that replaces just the Add Existing file dialog and only on those platforms that use non-native dialogs such as Windows, MacOS and maybe AppImage Linux builds. Repo based Linux builds and self-builds should still use their own native file dialog here if one exists with their choice of desktop.
|
My newest self build of Sigil on Arch is using the non-native dialog for Add Existing. It seems to work OK, but I read the above to mean that regular builds would behave like before (native dialog). Did I get that wrong? Or perhaps Linux was always using a non-native for Add Existing?
I've not yet found the code where (or if) you've attempted to limit the use of the non-native dialog to only the Linux AppImage to see why that may be.
It works fine, for the record! The image preview is great (and fast). The text preview isn't very useful for me on Linux or Windows as it stands, however. The text is very, very tiny, and when using a dark theme, the font looks very muted. The text is more legible (darker) in a light theme, but it's still tiny very tiny. I can basically see the shape of the paragraphs.
The white background of the text preview is also bit jarring in a dark setting. But as you already mentioned somewhere, I'm not sure a full-blown QWebEngineView is the way to go here (to have better/more control over how the preview looks). Perhaps a setting to opt out of the text preview would be simpler/more appropriate if nothing can be done about the text preview background?
Thanks!
EDIT: just confirmed that earlier builds of Sigil on Linux were definitely using a native dialog for Add Existing. I'm not opposed to switching; I just wanted to be sure I was understanding how it
should be working right now in a regular (or repo) Linux build.