|
@DiapDealer,
I just pushed a modified version of that routine plus all the other changes to centralize initialization of QFileDialog::Options into Utility::DlgOptions() all throughout the Sigil code.
I added in the env var override but we could remove it easily enough if we do not decide to go that way.
I do think with this new approach everything is centralized making it easier to make global platform changes later and it lessens the need for ifdefs everywhere throughoput the code that invoked a QFileDialog while adding just a few to Utility::DlgOptions(). It really removed a lot of Q_OS_MAC ifdefs.
Note: Utility::DlgOptions() has an added parameter special_case (defaults to an empty string) that should be flexible enough to allow us to make exceptions in any place we will need to in the future. I use it now just to match exactly what we had been doing before this change.
Please give it a look see and let me know if you want me to revert any or all of it.
Hope this helps!
|