View Single Post
Old 06-07-2025, 04:54 PM   #60
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,809
Karma: 6000000
Join Date: Nov 2009
Device: many
Quote:
Originally Posted by DiapDealer View Post
Yes. I think the non-native dialog just handles this situation better on Windows. It works quicker, and automatically notifies the user that there's a problem. And an isFileReadable check for all platforms for safety makes sense.
Agreed. Will you push those changes to BookBrowser.cpp or do you want me to?

Either way, we have time as we merged in new strings, so after your change I will update base.ts and we can let the translators get started on them while we wait in case other bugs are reported. And no need to rush out a 2.5.3 since this is not a usual crash, but requires copying and pasting in a url by the user when asked for a file path.
KevinH is offline   Reply With Quote