I'm pretty sure Windows still does, but I'll double-check to be sure.
Remember that it's QApplication that's being wrapped. That's how it makes it easy to load translators for qtbase strings, and for the plugins' strings themselves. It also allows fonts to be matched from Sigil to plugin. Matching Sigil's dark palette is false by default in the wrapped QApplication. So if plugin devs do nothing with the match_dark_palette parameter, that functionality will be skipped anyway.
OK, I checked, and on Windows the Qt plugins will auto switch when going from light to dark and back. But left to its own devices, PySide6/Qt will always use the inherent Windows dark palette. Meaning if a Windows Sigil user is using Sigil's custom dark palette, the plugins won't match Sigil's dark color palette. Not a huge deal to me if plugin devs don't want to worry about it, but I'd like to leave the option to match the dark palette in there (but defaulting to false) for those that might want to.
Remember... I have no reservations about plugin devs avoiding the plugin_utils (full or light) altogether if they do choose. If we remove the wrapped QApplication from the light version, then that's essentially what they'd be doing anyway. There'd be nothing left for it to do.
Last edited by DiapDealer; 05-28-2025 at 10:56 AM.
|