[JimmXinu]

This is very useful info, thanks!

Originally Posted by applegaa

I installed the latest test version before checking small groups of stories for new chapters.

The first thing I noticed is that the fetching metadata is still happening in a single process rather than one per site. I'm guessing that was intentional rather than oversight, but I wanted to mention it, as it seems to lead into the bigger issue I noticed.

Correct. Initial metadata fetch happens in the foreground because of all the various pop-ups and story URL changes that could happen.

Originally Posted by applegaa

If none of the stories in the group have updates, I get a single request to update the metadata, and it updates the "Last Checked" value on all of the stories. I then get an "ERROR: Unhandled exception" with "KeyError: 'site'"

Spoiler:

calibre, version 8.4.0
ERROR: Unhandled exception: <b>KeyError</b>:'site'

calibre 8.4  embedded-python: True
Windows-10-10.0.19045-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.19045')
Python 3.11.12
Windows: ('10', '10.0.19045', 'SP0', 'Multiprocessor Free')
Interface language: None
EXE path: C:\Program Files\Calibre2\calibre.exe
Successfully initialized third party plugins: Gather KFX-ZIP (from KFX Input) (2, 25, 0) && DeDRM (10, 0, 3) && Package KFX (from KFX Input) (2, 25, 0) && Consolidate All Library Metadata (2, 0, 46) && Count Pages (1, 13, 6) && EpubMerge (3, 2, 0) && EpubSplit (3, 10, 0) && FanFicFare (4, 45, 9) && Find Duplicates (1, 10, 9) && Job Spy (1, 0, 239) && KFX metadata reader (from KFX Input) (2, 25, 0) && From KFX (2, 25, 0) && KFX Input (2, 25, 0) && MultiColumnSearch (1, 0, 96) && Obok DeDRM (10, 0, 3) && View Manager (1, 10, 3)
Traceback (most recent call last):
  File "calibre\gui2\proceed.py", line 232, in do_ask_question
  File "calibre_plugins.fanficfare_plugin.fff_plugin", line 2128, in proceed_func
  File "calibre_plugins.fanficfare_plugin.fff_plugin", line 2273, in update_error_column
  File "calibre_plugins.fanficfare_plugin.dialogs", line 686, in LoopProgressDialog
  File "calibre_plugins.fanficfare_plugin.fff_plugin", line 1988, in update_books_finish
KeyError: 'site'

Got it--fix in next test version.

Originally Posted by applegaa

However, if there are stories that do have updates, only those stories seem to be passed on to the next step, so the "Last Checked" value is not updated on the stories that don't have updates and no error pops up.

This also means that any errors captured while fetching metadata are lost, unless there are no good updates.

I do see that happen, and it doesn't happen when I turn all three of the new options off. So it's definitely something with the new code. Not sure what yet.

Originally Posted by applegaa

Also, just an FYI, if you turn off the reconsolidation option, only the stories from the last site to finish remain marked, as all previous marks are cleared. It seems obvious, now...

That's a good point. That's working as designed, but may be a surprise. Not sure what could/should be done about it...