View Single Post
Old 01-22-2025, 05:40 AM   #53
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,475
Karma: 8025702
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by un_pogaz View Post
When I first saw the icon rule viewer, displaying the internal value assosiated to template bothered me a little because it wasn't {template} and so is wasn't consistent with other locations when a template is used to generate value. It really stuck in my mind for a while, but I couldn't find a way to write a good code to proposal.
Here my suggestion: Since the column "Use for children", write then a text {template}.

...
And now that I think about it, maybe it would be better than the internal value TEMPLATE_ICON_INDICATOR use " {template} " has value directly rather than " template " as is currently the case. Hm, it broke a bit if the user and test the feature on preview, but it's the risk of using preview and it will better display the fact that this icon rule is a template generator (instead that my suggestion above).
I originally did something like your first proposal but ran into problems with using the text as the dict key. I decided to make things easy and use the key directly, which meant using TEMPLATE_ICON_INDICATOR. Now that all the infrastructure changes are done I will go back to the browser. What I am looking at is adding icons saying what the value is using a different value for templates by using custom QTableWidgetItems.
chaley is offline   Reply With Quote