View Single Post
Old 12-24-2024, 12:53 PM   #5
joshuacant
Junior Member
joshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toysjoshuacant shares his or her toys
 
Posts: 8
Karma: 5662
Join Date: Jan 2023
Device: none
Quote:
Originally Posted by hius07 View Post
Thanks for sharing!
Anyone who wants to try, please stick to the 2024.11 release.
It won't work on the recent nightly builds because of
https://github.com/koreader/koreader/pull/12845
https://github.com/koreader/koreader/pull/12857
Chasing after changes made to KOReader has been a challenge. We originally built it around 202407 and had to do a bunch of unexpected work to fix it for 202411. I'm sure the fault lies with us, we're probably not doing things the "right" way, and as a result the plugin is more fragile. Part of getting this initial WIP release out is to see if anyone has feedback on what we could be doing differently.

I added checks in the plugin to try to prevent a situation where someone is locked out of KOReader due to the plugin crashing, by checking for a version number and then not loading the plugin. However right now it's only checking for a minimum, not a maximum. I will probably change that going forward so that each version of the plugin is limited to a single version of KOReader.
joshuacant is offline   Reply With Quote