View Single Post
Old 12-17-2024, 02:28 AM   #6
un_pogaz
Chalut o/
un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.un_pogaz understands the importance of being earnest.
 
un_pogaz's Avatar
 
Posts: 441
Karma: 145424
Join Date: Dec 2017
Device: Kobo
Yeah, the nigth give me the same advice.

For this one (legacy format strings), I will use a option of Ruff that do it automaticly for the vast of them, do it manualy for the others, then reverse any translation string that will be affected before commit. I know that this one will be the more tricky, so I will be very carefull.
Double carefull in view of the mistake from the previous pull request, who could have been avoided if I had made this before to fix the translation strings .


Beside, here what my workflow and the result will take form:
  • I perfom several fix and commit then by category, so that you can easly read the changes which are similar
    • Eventualy a commit with a single rules errors fix, if the change a more caution to make/read
  • A rebase frequently my commits, so that the final pull request will be have none merge conflict
un_pogaz is offline   Reply With Quote