View Single Post
Old 11-03-2024, 03:41 PM   #1404
Comfy.n
want to learn what I want
Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.Comfy.n ought to be getting tired of karma fortunes by now.
 
Posts: 1,662
Karma: 7908443
Join Date: Sep 2020
Device: none
Quote:
Originally Posted by capink View Post
Try the version attached below and see whether it works. This happened after calibre was updated to version 6 with some changes to icon management. I did not fully port the whole code at the time. The changes affect the following parts of the plugin:
  • Chains dialog.
  • Actions dialog.
  • Events dialogs.
  • Calibre Actions.
  • Chain Variables
  • Single Field Edit.

So please, if you have the time, test these areas to make sure everything is working properly before releasing any new version. I am not much interested in theming, and I guess it will be the same for most users.
Wheee, it works! I did a few tests in each area and all seems fine:

Click image for larger version

Name:	2024-11-03 17_14_15-Chains Dialog.png
Views:	200
Size:	36.7 KB
ID:	211835

Click image for larger version

Name:	events MWSnap 2024-11-03, 17_21_18.png
Views:	201
Size:	20.8 KB
ID:	211834

Quote:
That is a matter of opinion. I personally think the priority should be to custom icons.
Actually what I wanted to mean was that, according to the comments in the code, the icon theme images were expected to be used in preference to the resources folder.

I too think that the resources folder must have higher priority than the themes. And upon a quick test using distinct icons for the main plugin icon in the theme and in resources folder, all is working fine as well: the image that shows in Calibre main toolbar is the one in resources.

edit to add - now that I looked again at the comments in the code, it's clear that I got things mixed up:

Click image for larger version

Name:	MWSnap 2024-11-03, 17_45_47.png
Views:	197
Size:	8.0 KB
ID:	211836


Last edited by Comfy.n; 11-03-2024 at 04:52 PM.
Comfy.n is offline   Reply With Quote