New Test Version Posted
2024-09-28
- Fix(es) for get_url_search not found when seriesUrl doesn't match an adapter site.
- Fix for regression when browser_cache_simple_header_old added. Closes #1104
Quote:
Originally Posted by Jager956
2. Tried some random book from royalroad.com with calibre and FFF: download successful!
3. Tried again some other book from SOL: same problem as before.
|
I'll be honest--when I saw the same error as another user reported prior (with solution no less), I didn't look very deeply. So points to you for being persistent.
There is a bug here. But it's obscure. I mean
really obscure. As in, you may be the only user who would ever see it.
When I updated the code to move the get_url_search() code to the adapters, I included a 'last ditch' case for not matching the search URL to any adapter. But my normal testing didn't exercise that code and it had a bug.
In fact, the
only way (I know of) to hit that code is to have "Check for existing Series Anthology books?" checked and then have a story with a series value either without a seriesUrl value or a seriesUrl value that isn't on any supported site. If that's a thing in normal use, I don't recall it.
Enter Jager956. Back in January. January 2021, that is.
Quote:
Originally Posted by Jager956
Just to clarify; I am using series column because of kindle (collections). And this configuration for SOL site is great as I group stories from SOL based on sex rating. If any story is in series/universes, I use that info in custom column just for cover generation.
|
Quote:
Originally Posted by JimmXinu
You can do that with include_in_X. For example, include_in_series:rating will copy rating into series.
|
So the new test version both skips the anthology search if there isn't a seriesUrl value and corrects the 'last ditch' get_url_search() case.