View Single Post
Old 08-29-2024, 03:40 PM   #74
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,915
Karma: 6120478
Join Date: Nov 2009
Device: many
Quote:
Originally Posted by philja View Post
re: Doitsu's warning dialog problem illustrated by his file 'no_doctype_epub3.epub'

I now have Sigil 2.3.0 on my linux box and W10 box and the 2.3.0-1 on the MacBook. Only the MacBook gives the same warning as the illustrations supplied by Doitsu.

The linux and W10 boxes both supply an identical message conveying essentially the same warning but probably an older version.


Sigil on linux was built from source and the W10 version was downloaded and installed normally and replaced earlier versions.

How should I ensure that 'everything' gets upgraded when a new version is built/ installed? Should older config files be destroyed?

That is very strange... are you sure you built from official github sources for the Sigil 2.3.0 tag?

There were some Beta releases that did not have those fixes but the final released Sigil-2.3.0 certainly had them.

Here is the snippet of code from ImportEPUB.cpp that is in Sigil 2.3.0

Code:
    if (autofix) {
            foreach(HTMLResource* htmlres, non_well_formed) {
                QString fixed_text = CleanSource::Mend(htmlres->GetText(),htmlres->GetEpubVersion());
                htmlres->SetText(fixed_text);
            }
            non_well_formed.clear();
            QString warning = tr("This EPUB had HTML files that were not well formed or are "
                   "missing a DOCTYPE, html, head or body elements.<br/><br>They were automatically fixed based on "
                   "your Preference setting to Clean on Open.");
            warning = warning + SEP + problem_files.join("\n");
            AddLoadWarning(warning);
        } else {
            QString warning = tr("This EPUB has HTML files that are not well formed or are "
                   "missing a DOCTYPE, html, head or body elements.<br/></br>Fix these manually or use "
                                 "Sigil's Mend tool to automatically fixed these errors or omissions.");
            warning = warning + SEP + problem_files.join("\n");
            AddLoadWarning(warning);
        }
    }
On Linux, perhaps your distribution version of Sigil (and older one) is being found in your path first? Did you do the sudo make install after make completed?

On Windows could you have an old version being run instead.

What does the About Sigil dialog say on both (exactly). A screen shot of each About box would help.

Typically to build from source you download the source code directly from the Releases page and unpack it and build from there. If you did a git clone earlier to get the source you need to use git to pull in all changes since your prior pull or clone before doing your build.

Last edited by KevinH; 08-29-2024 at 03:51 PM.
KevinH is offline   Reply With Quote