Quote:
Originally Posted by BeckyEbook
BTW,
While testing version 2.3.0 (beta2) on Windows, I think I see a bug.
With "User Classic Sigil Dark Theme" enabled, the two close/undock images are very tiny.
|
If I followed the code correctly they should be the same undock and close svg icons used in the SigilDarkStyle.cpp i.e. determined by win-dark-style.qss in the Resource_Files/dark/ resource.
Which gives us the following:
QDockWidget::float-button, QDockWidget::close-button {
border: transparent;
background: transparent;
padding: 0;
icon-size: 9px;
}
QDockWidget {
titlebar-normal-icon: url(:/dark/undock.svg);
titlebar-close-icon: url(':/dark/dock-close.svg');
}
The ones when the native qt dark mode for windows are set by qss in main.cpp :
const QString LINWIN_DOCK_TITLEBAR_FIX =
"QDockWidget { "
" titlebar-close-icon: url(:/dark/dock-close.svg);"
" titlebar-normal-icon: url(:/dark/undock.svg);"
"}";
So both dark themes use the exact same svg images. But the classic dark theme uses smaller dock titlebar icons because of qss icon-size.
But that code is over 5 years old and I think you wrote it or helped write it, correct?