View Single Post
Old 08-09-2024, 01:58 AM   #12
Majutsushi
Zealot
Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'Majutsushi knows the difference between 'who' and 'whom'
 
Posts: 109
Karma: 10128
Join Date: Aug 2023
Location: New Zealand
Device: Kobo Clara HD, Kobo Libra Colour
The plugin currently only downloads a single cover if it finds an ISBN match because I thought that getting the right cover for the specific edition was enough and I wanted to reduce the number of queries due to the rate limit, but I agree that the covers for alternative editions can also be desirable. As for why in DNSB's case it returns 10 covers instead of 5 that's because the limit is per-store, not absolute, which I probably should have made clearer.

Here's a version where I made some changes around this:
* It now always does a search, even if there's an ISBN match, to allow for alternative covers.
* It always returns at most the actual number of covers configured.
* If two stores are configured, it will prioritize the first results from each, since those are going to be the most relevant ones.

With these changes, if I configure the stores to be US and UK with two max covers, I get exactly the two US and UK covers for DNSB's book.

Unless someone finds a bug with this I'll release it as the next version, although I'm not sure if I can currently edit my initial post to change the attachment.
Attached Files
File Type: zip Apple.Books.covers-v0.1.0-1-ge618477-dirty.zip (21.6 KB, 574 views)
Majutsushi is offline   Reply With Quote