View Single Post
Old 04-16-2024, 07:28 PM   #88
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,444
Karma: 5703082
Join Date: Nov 2009
Device: many
Yes, tabbing between dockwidgets will continue until some future release.

The focus highlight border can now be applied to both CodeView and Preview and it works.

Redrawing title bars requires overloading the paintEvent in each widget and replacing it with our own. No need now that the border works.

Find and Replace is not a QDockwidget. It is a child window of our MainWindow that is shown and hidden. Its position is locked and it can not be undocked. That means it has no titlebar. As for where the X close is. It is manually added and has been in the same place forever, and is not moving given the 10 years of muscle memory I have built up. You'll have to just live with it.

It was designed as part of the main window (just like TabManager and CodeView) so that it can be integrated visually and codewise with them. Again, a decision we will not be revisiting as it makes good sense.


Quote:
Originally Posted by BetterRed View Post


Should I assume nothing sensible can be done about tabbing between 'widgets' without significant effort?

Circling back to my the original issue - visibility of which child window has focus. If the coloured border solution can't be readily applied to the Codeview and Preview windows, how about changing the colour of the dockable child title bar.

On Windows, if a dockable child is undocked, then its title bar will have the "Accent" colour when it has focus - i.e the border is redundant. So, why not do the same when its docked. When Codeview has focus the tag on the current tab-panel item could use the same colour. viz:

Attachment 207657

Maybe the F&R non-dockable child window could be given a title bar too, then its 'X' could be put where it belongs, at the far right - rather than the loony left :-)

Curious - why isn't the F&R child window dockable?

BR
KevinH is offline   Reply With Quote