View Single Post
Old 04-14-2024, 11:53 AM   #1087
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,252
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by driuba View Post
I'm not sure what kind of patches get included to the main repo, but I sure be thankful if this was. I could make a pull request if needed.
I notice your patch name includes "(Libra2)". Usually an "official" patch would be expected to work for everyone who enables it, i.e. all existing Kobo models from Kobo Touch and Kobo Mini onwards. You would also be expected to maintain it by making sure it still works after each new firmware release. Otherwise it should probably stay as a personal patch which, of course, you are free to share as and when you like.

I'm not sure whether you know this but you can split off your libnickel personal patches into a separate custom .yaml file (e.g. libnickel_driuba.yaml) and edit the kobopatch.yaml file to include this extra yaml. In this way you can carry over the pre-customised personal patches (often unchanged) from firmware to firmware. If this appeals to you I could help you set it up for yourself. It takes longer to explain it than to do it. Here's a link to an old post where I attempted to explain it to another user.
jackie_w is offline   Reply With Quote