View Single Post
Old 12-13-2023, 03:43 AM   #209
slowsmile
Witchman
slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.slowsmile ought to be getting tired of karma fortunes by now.
 
Posts: 628
Karma: 788808
Join Date: May 2013
Location: Philippines
Device: Android S5
@DNSB,
@BeckyeBook,
@nabsltd,

I've put in all @BeckyBook's fixes and I've just tested the new fixed version of the plugin. I just want to clarify and confirm how the new plugin version behaves now.

When I run the new plugin with the "Remove empty spans" option selected with this epub code:
Code:
<p><span>This is a plugin test run</span></p>
The html is changed to this -- all empty spans(with no attributes) are removed:
Code:
<p>This is a plugin test run</p>
Also, if I run the new plugin with no options set and run it on this code:
Code:
<p>This <span> </span>is a plugin test <span class="P1"> </span>run</p>
I get this as a result:
Code:
<p>This is a plugin test run</p>
I can also confirm that when I ran the same tests using @BeckyeBook's plugin version -- I got the same results.

Is everyone now happy with the new plugin's behaviour? I will be releasing the plugin tomorrow morning, so please let me know your thoughts before then.

Last edited by slowsmile; 12-13-2023 at 04:13 AM.
slowsmile is offline   Reply With Quote