View Single Post
Old 09-15-2023, 04:38 AM   #226
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,476
Karma: 8025702
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by kovidgoyal View Post
that commit assumes images are in the plugin root which. I suppose adding support for an extra images sub-folder shouldnt be too bad.
This is more-or-less required, because plugins put the default icons in an images subdirectory in the zip file.

And FWIW: if I remove 'images' as in
Code:
icon = get_icons('icon.png', 'Interface Plugin Demo')
it works if the overridden icons exist. As a consequence of the above, it doesn't work if there aren't any overridden icons.
chaley is offline   Reply With Quote