View Single Post
Old 09-15-2023, 12:48 AM   #221
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,041
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Okay, I've taken a look at overriden_icon_path() in calibre/gui2/__init__.py. I think it's broken for plugins.

overriden_icon_path() is looking for -for-light/dark-theme files in override_items, which is built from looking for files in 'devices', 'mimetypes', 'plugins' dirs under resources/images.

Probably works fine for devices and mimetypes, but not for plugin custom icons.

Currently, plugin custom icons are under resources/images/<pluginname> for each plugin, not under resources/images/plugins. And just putting the pluginname dir under 'plugins' doesn't work because the code doesn't recurse.

Adding 'FanFicFare' to the 'devices', 'mimetypes', 'plugins' list works, but I don't know if adding all plugin names to that list is an appropriate solution.
JimmXinu is offline   Reply With Quote