View Single Post
Old 07-23-2023, 02:38 PM   #8707
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 7,043
Karma: 4604637
Join Date: Dec 2011
Location: Midwest USA
Device: Kobo Clara Colour running KOReader
Quote:
Originally Posted by JimmXinu View Post
You've exactly identified it. FFF is using the list, not the string.

The code for getting include_subject_tags is specifically calling for the lists (keeplists=True) which bypasses _LIST processing.
...
After thinking about this for a while, I think the best solution may be to simply use the string version of each metadata entry in include_subject_tags and split by comma(,).

In some ways, this gives the user more control because they can use join_string_X to use a different separator than comma(,) to force an entry to be all one Tag, with a label even: <dc:subject>Genre: Action; Drama<dc:subject>

This does cause a change in behavior from the existing code: Value "A, B" will be come tags "A" and "B" instead of "A; B" in Calibre's tags.

In practice, I first expected this to be rare. But searching my own library found tags "House; M.D." and several variations on "Title; The" which were ',' on the site. ~100 books in my library of ~6200. With the proposed change, these would end up as tags "The" and "Title".

All of my examples come from tthfanfic.org, but how many other sites do something similar?

This could be handled with a couple replace_metadata lines. Or even a simple category,genre=>,=>; but I hesitate a lot to add add_to_replace_metadata lines to defaults.ini. And doing it in code would be worse.

So still thinking...
JimmXinu is offline   Reply With Quote