Hmmm.. might not be a bug. But it's still not right. I could have sworn we had more validation than a base_name that doesn't already exist and the presence of a plugin.xml file. @Kevin: didn't it use to check that the name in the plugin.xml matched the folder name and the base name of the zip file?
EDIT: Nevermind. Now I see. The base name of the zip (minus any version info) is checked against the internal folder name to see if they match. If they do match, and a plugin.xml file is present, then Sigil sees the plugin as valid. Which means downloads of branch sources from my github plugin repositories are going to be considered valid. At least for installation purposes. But not for running or removal purposes. That's unfortunate.
Last edited by DiapDealer; 04-24-2023 at 12:59 PM.
|