View Single Post
Old 10-15-2022, 12:58 PM   #1009
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,529
Karma: 8075938
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by kiwidude View Post
I do suspect I know what the issue is if that is indeed the case. I tried not to change the underlying approach which is to get a list of authors only and compare their names. Whereas the 1.9.7 version iterates across all the books, and then compares the authors from those books.
This might be an instance of the performance problem I worried about in this post in the development thread. The original code I wrote used the underlying API, but in a way that required the reversal of the {id:authors} dict for every author query. Say there are 5000 authors. That would be 5000 reversals of a 5000 item dictionary every time the id/name pairs are fetched.

I suggest you try it with the changed code, which does the reversal once then uses the reversed dict. This should be no slower than the old method that ignored VLs.
chaley is offline   Reply With Quote