View Single Post
Old 09-06-2022, 12:36 PM   #617
kiwidude
Calibre Plugins Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,733
Karma: 2197770
Join Date: Oct 2010
Location: Australia
Device: Kindle Oasis
Thanks for giving it a run so quickly Eskoe and your logs, very helpful. It allowed me to confirm that you were exclusively hitting the "old" html pages with all those books - i.e. they would have coincidentally still worked with the old 1.5.x plugin. So at least I know that side of things is still working well, I will wait a little longer for feedback from others before releasing in the hope they happen to hit the new code more.

Unfortunately there is no guaranteed way I found to force it to hit one version of the Goodreads book page over another at the moment (which made testing my changes a pain). It is genuinely a heads or tails coin flip every time. I had to sit there doing Download -> View Log -> Cancel over and over each time I wanted to test something with specific page variants...

Incidentally if you are bored/curious and want to know what to look for in the logs - if you see "_legacy" in those log files then it is the "old" website page design (e.g. "parse_isbn_legacy: xxxx"). Whereas with the new web page the log will just say "parse_isbn: xxxx". There are other lines in there which point out more explicitly but that is the quickest way to skim read the answer.
kiwidude is offline   Reply With Quote