Quote:
Originally Posted by JimmXinu
That was my thought as well from the initial error "TypeError: '<' not supported between instances of 'int' and 'NoneType'".
But the FFF code only calls set_marked_ids() with a dict that contains id->string value, or an empty dict() to clear all marks. No where does it set a boolean or a None into the dict. And I haven't been able to reproduce the reported issue.
|
I think I know what is happening but I won't be able to work on it for a week or so. The marked set can apparently contain the ids of deleted books. These might change to a book id of None. Alternatively, someone passed a set containing {None:'aaa'}. In any event, a key of None should be filtered out.
Quote:
|
This new named marking UI conflicts a bit with the way Reading List PI and FFF have used a unique, numbered named mark on each book to both mark and order. I wonder if having hundreds or thousands of uniquely named marks (from viewing a Reading List) will cause problems? My 5k+ library fills the screen on 'Show marked books with text' but otherwise is fine.
|
I will change it to show only the first 40 (arbitrary). More than that were probably produced programmatically and aren't useful, and can be done with search.
Quote:
|
FYI, the new 'Mark with text label' action will allow an all whitespace label. And treats one space and two spaces as different labels. Doesn't seem to hurt anything, but may not be desired.
|
That isn't good.
I will fix it.