View Single Post
Old 04-23-2022, 12:12 PM   #1636
lomkiri
Groupie
lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.lomkiri ought to be getting tired of karma fortunes by now.
 
lomkiri's Avatar
 
Posts: 170
Karma: 1497966
Join Date: Jul 2021
Device: N/A
Quote:
Originally Posted by DaveLessnau View Post
In my case, the test_4 version failed. It looks like it worked regarding the ToC, but overall it came back saying it failed:
It seems that there is no error, but that when mod-epub don't find anything to correct, it emits this msg (in action.py). Do you confirm, Chaley ?

Spoiler:
Code:
    def _modify_completed(self, job):
        if job.failed:
            self.gui.job_exception(job, dialog_title=_('Failed to modify ePubs'))
            return
        modified_epubs_map = job.result
        self.gui.status_bar.show_message(_('Modify ePub completed'), 3000)

        update_count = len(modified_epubs_map)
        if update_count == 0:
            msg = _('No ePub files were updated')
            return error_dialog(self.gui, _('Modify ePub failed'), msg,
                                show_copy_button=True, show=True,
                                det_msg=job.details)


Edit:
Oops, once more I missed the train, you answered while I was writing ;-)
Maybe it will be better if there is an info_message() instead a error_message, since mod-epub didn't failed at all, it just worked on a perfect epub ;-)...

Last edited by lomkiri; 04-23-2022 at 12:18 PM.
lomkiri is offline   Reply With Quote