Quote:
Originally Posted by aik099
That's interesting. Thank you.
I've done some review (not a Phyton developer myself). There are really some cool features present in your PR, that deserve a separate PR. Also some nice bug fixes in there.
What I'm not sure about is https://github.com/davidfor/calibre-...cde#r851656646 change. @davidfor, can you please explain the use case of the to-be-removed code so that we can address the issue that Moon Reader import has with it? |
I removed the code you were concerned about, and went a different direction. It looks like most of the other exporting readers take a paste of some data in a text box. For moon reader, we want to import the backup zip file, so I added a file picker option. I broke that and the default colors as per your suggestion to different PR's.
Until those land I'd hold off on reviewing the Moon reader PR, so I can rebase and you'll see a clean diff.