Thread: [GUI Plugin] Annotations
View Single Post
Old 04-17-2022, 01:24 PM   #1026
aik099
Enthusiast
aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!aik099 rocks like Gibraltar!
 
Posts: 35
Karma: 100180
Join Date: Apr 2020
Device: none
Quote:
Originally Posted by stbenjam View Post
I've cobbled together a basic support for Moon+ Reader, would be interested in feedback and for someone else to try it.

https://github.com/davidfor/calibre-annotations/pull/23
That's interesting. Thank you.

I've done some review (not a Phyton developer myself). There are really some cool features present in your PR, that deserve a separate PR. Also some nice bug fixes in there.

What I'm not sure about is https://github.com/davidfor/calibre-...cde#r851656646 change. @davidfor, can you please explain the use case of the to-be-removed code so that we can address the issue that Moon Reader import has with it?
aik099 is offline   Reply With Quote