View Single Post
Old 11-28-2021, 06:20 AM   #82
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,252
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by Sirtel View Post
Hmm. I use several of these patches on my Libra 2 and frankly I haven't even noticed that something was wrong. To me they seemed pretty much the same as on my Libra H2O.
Apologies if I've worried you unnecessarily. There is nothing major wrong with the 4.30.18838 nickel.yaml patches. They will all work fine as-is for anyone who:
  • only changes 'Enabled: no' to 'Enabled: yes'
  • has a new Libra2 but has already changed some default values in some nickel.yaml patches to be "just right" for an older LibraH2O
  • has a new Elipsa but has already changed some default values in some nickel.yaml patches to be "just right" for an older AuraOne/Forma

The Libra2 "wrongly labelled" problem I referred to above will only be a problem if you decide a particular nickel.yaml patch as-is is not quite "perfect" for your Libra2 and you've never owned a LibraH2O. When you try to customise the patch with your new "perfect" values the help labels/comments are directing you to change the wrong value.

If you're interested, here's an example to illustrate what I mean. The red comments should be the blue comments.

Extract from current Reduce new header/footer height patch:
Code:
        # AuraHD/AuraH2O/AuraH202/ClaraHD/Elipsa/Libra2 (Dragon)
      - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  min-height: 101px;\n  max-height: 101px;\n}"
        Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  min-height: 66px;\n  max-height: 66px;\n}"
        # AuraOne/Forma/Sage (Daylight)
      - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  min-height: 131px;\n  max-height: 131px;\n}"
        Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  min-height: 86px;\n  max-height: 86px;\n}"
        # LibraH2O (Storm)
      - Find:    "ReadingFooter[qApp_deviceIsStorm=true] {\n  min-height: 118px;\n  max-height: 118px;\n}"
        Replace: "ReadingFooter[qApp_deviceIsStorm=true] {\n  min-height: 78px;\n  max-height: 78px;\n}"
and this is what it should be:
Code:
        # AuraHD/AuraH2O/AuraH202/GloHD/ClaraHD (Dragon)
      - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  min-height: 101px;\n  max-height: 101px;\n}"
        Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  min-height: 66px;\n  max-height: 66px;\n}"
        # AuraOne/Forma/Sage/Elipsa (Daylight)
      - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  min-height: 131px;\n  max-height: 131px;\n}"
        Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  min-height: 86px;\n  max-height: 86px;\n}"
        # LibraH2O/Libra2 (Storm)
      - Find:    "ReadingFooter[qApp_deviceIsStorm=true] {\n  min-height: 118px;\n  max-height: 118px;\n}"
        Replace: "ReadingFooter[qApp_deviceIsStorm=true] {\n  min-height: 78px;\n  max-height: 78px;\n}"
jackie_w is offline   Reply With Quote