Thread: Possible bug?
View Single Post
Old 09-14-2021, 07:01 PM   #86
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,861
Karma: 6120478
Join Date: Nov 2009
Device: many
Hi BeckyEbook,

Those patches look good to me! I think we still have to add in something to make the "you need to restart for these changes to take effect" part work.

I will apply them to my local tree and make sure they build on macOS. If so, assuming DiapDealer is okay as well, we can push them to master and create a deploy build for other Windows with international keyboards to test with.

BTW, does making this change mean we can close this issue:

https://github.com/Sigil-Ebook/Sigil/issues/580

since the default shortcuts should work if that box is checked. Or am I misunderstanding?


Edit .... after rereading that issue 580 again, I think there is still a need for default sigil ini file just for international users, right?


Quote:
Originally Posted by BeckyEbook View Post
Diffs.

Last edited by KevinH; 09-14-2021 at 07:13 PM.
KevinH is online now   Reply With Quote