View Single Post
Old 09-13-2021, 10:01 AM   #692
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,471
Karma: 8025600
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by capink View Post
How do you think this will impact calibre's performance?
It could go either way. Setting a field to its current value will be significantly faster because it isn't dirtied (queued for metadata backup), the last_modified isn't set, and in several cases a database update is avoided.

If a field is really being changed: many-to-many fields like tags won't see a hit because they already did the optimisation. Other fields now have a bit more processing to check if the value is being changed. In some cases a field was being updated twice (e.g., custom series indices), which is no longer happening.



I will make a pull request and see what Kovid thinks.
chaley is offline   Reply With Quote