Quote:
Originally Posted by KevinH
But if you launch it when the OPF is the current file it should enable file watchers for all the xhtml files no matter what target (ie. PageEdit or not) is used. If not, I think we should put it back that way.
What do you think?
|
Quote:
Originally Posted by DiapDealer
I'm not sure I can put it back. The logic is pretty twisted already. Right now, it passes the highlighted xhtml file as an argument to the external editor (and the filewatcher is started). Unless the external editor in question is PageEdit, in which case the OPF file and the currently highlighted xhtml file are both passed to PageEdit as arguments (and the multiple watchers are set up by parsing the opf). If no xhtml file is highlighted in Book Browser, nothing happens (see message in status bar). It was determined that users who wanted to open a single xhtml file with PageEdit could do so via the right-click "Open With" in Book Browser.
I guess it just doesn't seem that intuitive to me to select an opf file in Book Browser before activating an external xhtml editor. But I'm up for anything if we can figure it out without breaking the current functionality.
|
Apparently I'm all wet on this. The Launch External xHmtl editor feature isn't working at all the way I intended it to with my last few changes.
It seems when PageEdit is defined as the external editor, PageEdit is launched with all xHtml resources available regardless of what kind of file is highlighted in Book Browser. Doesn't matter if it's an image, or a css file, or the opf file.
When the External xHTML Editor is defined as something other than PageEdit only xHTML resources can opened.
The latter is as I intended, but the former is not.
Though it's still not the end of the world at that. Always launching PageEdit with all html resources available whenever clicking the Launch External xHTML button was always the intended goal (whenever PageEdit is defined as the external editor, that is).