MobileRead Forums - View Single Post

KevinH · 08-05-2021, 11:11 AM

Okay, I see that in other places in the Sigil source code I already call:

Code:

m_Book->GetOPF()->UpdateManifestProperties(resources);

on a limited set of resources.

So I was being a big hypocrite saying "we should not" when we already do in two other places in the source code. I had forgotten about them. And I hate being a hypocrite.

So I have decided to run UpdateManifestProperties on just the resources touched by linking of the javascripts in that routine.

**BUT** [climbs back on to my soapbox!]
I still think it is really really important to run UpdateManifestProperties on *all* xhtml resources as one of the final steps since just text editing can create the need for it and there is no way for Sigil to easily tell if it is needed.

08-05-2021, 11:11 AM	#21
KevinH Sigil Developer Posts: 8,906 Karma: 6120478 Join Date: Nov 2009 Device: many	Okay, I see that in other places in the Sigil source code I already call: Code: m_Book->GetOPF()->UpdateManifestProperties(resources); on a limited set of resources. So I was being a big hypocrite saying "we should not" when we already do in two other places in the source code. I had forgotten about them. And I hate being a hypocrite. So I have decided to run UpdateManifestProperties on just the resources touched by linking of the javascripts in that routine. BUT [climbs back on to my soapbox!] I still think it is really really important to run UpdateManifestProperties on all xhtml resources as one of the final steps since just text editing can create the need for it and there is no way for Sigil to easily tell if it is needed. Last edited by KevinH; 08-05-2021 at 11:38 AM.