View Single Post
Old 04-14-2021, 05:09 PM   #84
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,950
Karma: 6361444
Join Date: Nov 2009
Device: many
I did find two other places that invokes UpdatePreview in MainWindow that might be an issue for opening new tabs for the first time:

The first is when Preview is first shown, or when hidden and shown again:

connect(m_PreviewWindow, SIGNAL(Shown()), this, SLOT(UpdatePreview()));

That may explain the minimize and restore double pump.


And the second happens when a tab change is made to a new tab here:


connect(m_TabManager, SIGNAL(TabChanged(ContentTab *, ContentTab *)),
this, SLOT(UpdatePreview()));

So when a new tab is created and loaded and then changed to (or in the reverse order) , we can end up with preview update being loaded twice.

Hmm Perhaps that is an issue once for each tab, but after that changing between two loaded tabs we would need that signal as both have already been loaded.

But all of this happens in Sigil 1.3.0 as well so I am not sure why it is causing an issue now and not then.
KevinH is online now   Reply With Quote