View Single Post
Old 04-10-2021, 12:34 PM   #46
DiapDealer
Grand Sorcerer
DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.DiapDealer ought to be getting tired of karma fortunes by now.
 
DiapDealer's Avatar
 
Posts: 28,693
Karma: 205039118
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
Quote:
Originally Posted by KevinH View Post
So it appears we will have to use an approach much like calibre does and automate the renaming to be unique at least among the set of files to be merged. For that we will have to add a SourceUpdater for Fragments to our codebase.

Thoughts?
Makes sense to me. Were we just offering to bail on the merge if it would result in duplicate ids in the same html file before (and doing nothing to fix them if the user chose to move forward with the merge anyway)?

The recent changes work great on my tired old testing laptop, too, by the way! A 20 second merge and no stuttering/freezing at all when navigating menus, or launching the Preferences dialog.

The issues were affecting Linux as well, by the way. Even my beast of a development machine was stuttering and freezing after the merge before these changes.

Last edited by DiapDealer; 04-11-2021 at 05:44 PM.
DiapDealer is online now   Reply With Quote