Looking at in more detail, some of my earlier assumptions were wrong and there were some more problems to deal with.
Settings like 'Manually add/remove items' etc did
not need a bunch of code changes for translation--the saved settings were already using 'POPMANUAL' etc.
Favourites Plugin is not going to play nicely with translated strings. It just isn't designed to. So any existing Spanish language users who have Favourites items from RL are going to have to update their Favourites settings.
Keyboard shortcuts, on the other hand, can been kept by
not translating the string used for unique_name. I've made those changes, but they are ugly because I don't know of any good way to have both the translated and untranslated strings available without duplicating them.
I'm not sure what tool dunhill used to find and wrap strings with _(), but in several places it wrapped more than one string that should have been separate. I think I've found them all, but it means there are more new strings that need translation for Spanish.
When testing translation code, I find it very helpful to have a fake language translation I call 'zz' included. It's just English with every translated string prefixed with 'zz' to make it easier for me to troubleshoot. I've included it in Reading List now.
Attached is a test version that (I think) has all the necessary code changes. It is missing a few Spanish translation strings now.
The messages.pot is in the zip and also available on github:
https://github.com/JimmXinu/JimmsOth...s/messages.pot