View Single Post
Old 04-04-2021, 12:05 PM   #1062
dunhill
Guru
dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.dunhill ought to be getting tired of karma fortunes by now.
 
dunhill's Avatar
 
Posts: 914
Karma: 810834
Join Date: Sep 2017
Location: Buenos Aires, Argentina
Device: moon+ reader, kindle paperwhite
Quote:
Originally Posted by JimmXinu View Post
Unfortunately, there are a number of things in dunhill's version that are translated that shouldn't be.

Things like settings keys and search values plus unique_name and favourites_menu_unique_name settings that will break existing keyboard shortcuts and Favourites for Spanish users.

Plus some other things aren't translated (settings like 'Manually add/remove items' etc), but probably should be. Except that they require code changes to de-couple the displayed value from the saved value first.

Attached is an incomplete version that has some (but not all) of the un-translate changes and none of the de-coupling changes. That's just how far I got before running out of energy for it for now.

I will review it and upload it again. Thanks for the clarifications. strings (settings like 'Manually add / remove items' etc) are enclosed in [ ].
When translating them, they give me an error when testing the plugin.
How should I mark them?

Last edited by dunhill; 04-04-2021 at 12:09 PM.
dunhill is offline   Reply With Quote