View Single Post
Old 02-20-2021, 08:31 AM   #350
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 12,486
Karma: 8025704
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by capink View Post
Not sure about this. I would say let's wait and see if there are any complaints. I don't like the familiar template language to change (unless absolutely necessary), or to have two ways to do the same thing. That might end up be more confusing for some people.
I agree, especially because book_vars() is a proper function while globals() is a language construct. globals() assigns values to the variables named as arguments. book_vars() doesn't do the assignment but instead returns the value for the user to use as needed.
Quote:
Yes the steps are carried out in the same order.

I have no problem with adding the option to not change selection. But I don't think it will used much except except maybe to display a search at the end of the chain without selecting any books.

If you combine a search with this new option, the current library view will change to reflect the new search, but no book will be selected. You have to combine the search with "choose all books in current view" or any other option to have books be selected.

Edit: I will do it because it might have some uses.
Another argument: my sample average rating chain selects the entire library to do the Single Field Edit action that assigns the result to all the books. I do that with "Clear Search" followed by "Select all books in current library view." After the Single Field Edit finishes I want to clear the selection. There isn't a way to do that.

I think that adding these two options cover all the possibilities:
  • Clear selection: no books are selected.
  • Select first book: the first book (line) in the view is selected. This option permits the chain to leave the library looking "normal".
Having either of the above is sufficient. Having both might be "gilding the lily".

Note that clearing the selection sort-of does select the first book. The "title" field is lightly highlighted. If you run Quickview docked then when the selection is cleared Quickview shows the information for the Author of the first book. Hitting the down-arrow button does an actual selection of the second book. Maybe this implies that the second option above is the best choice.

Last edited by chaley; 02-20-2021 at 10:13 AM.
chaley is offline   Reply With Quote