MobileRead Forums - View Single Post

capink · 02-13-2021, 07:01 AM

There is a problem with the selection modifier that needs addressing. The search option in the selection modifier did not take into account that some people might have the search highlight option enabled. So if someone with highlight option enabled, decided to use a new or saved search in the selection modifier, and checked the option to select all books in current view, it would actually select all books in the library, since that is the current view (unlike what happens if you do the same steps with the highlight option turned off).

There are two ways to deal with this:

Keep the selection modifier action as it is, but temporarily set the highlight feature off and restore it back after the action finishes. The advantage to this is that it is will not break settings configured with older versions. The code for this is already present in the Find Duplicates plugin, so it should be very easy to add.
Modify the selection modifier to directly select the books from a search without adding the new search to the search bar and without changing the current view. The selection is going to be within the confines of any previous search or virtual library (the option to clear any search or virtual libraries will still be included).

The advantage to this option is that it is cleaner, and the selection modifier should have been implemented this way from the start. The main problem with this approach; is that it will break actions configured with previous versions of the plugin.

Also since the selection modifier will not add the new search to the search bar, and consequently will not change the book view to reflect the chosen search, I can compensate for this by incorporating this previously posted custom action, as a built-in action in the plugin.

I am leaning towards the second solution, but since it breaks compatibility, I decided to post here first to seek input from others. As a transitional step, I might post a new version that implements the first solution, and then decide whether to pursue the second option or not.

02-13-2021, 07:01 AM	#315
capink Wizard Posts: 1,203 Karma: 1995558 Join Date: Aug 2015 Device: Kindle	There is a problem with the selection modifier that needs addressing. The search option in the selection modifier did not take into account that some people might have the search highlight option enabled. So if someone with highlight option enabled, decided to use a new or saved search in the selection modifier, and checked the option to select all books in current view, it would actually select all books in the library, since that is the current view (unlike what happens if you do the same steps with the highlight option turned off). There are two ways to deal with this: Keep the selection modifier action as it is, but temporarily set the highlight feature off and restore it back after the action finishes. The advantage to this is that it is will not break settings configured with older versions. The code for this is already present in the Find Duplicates plugin, so it should be very easy to add. Modify the selection modifier to directly select the books from a search without adding the new search to the search bar and without changing the current view. The selection is going to be within the confines of any previous search or virtual library (the option to clear any search or virtual libraries will still be included). The advantage to this option is that it is cleaner, and the selection modifier should have been implemented this way from the start. The main problem with this approach; is that it will break actions configured with previous versions of the plugin. Also since the selection modifier will not add the new search to the search bar, and consequently will not change the book view to reflect the chosen search, I can compensate for this by incorporating this previously posted custom action, as a built-in action in the plugin. I am leaning towards the second solution, but since it breaks compatibility, I decided to post here first to seek input from others. As a transitional step, I might post a new version that implements the first solution, and then decide whether to pursue the second option or not. Last edited by capink; 02-13-2021 at 08:01 AM.