View Single Post
Old 02-12-2021, 01:27 PM   #8
twowheels
Wizard
twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.
 
twowheels's Avatar
 
Posts: 1,854
Karma: 13432974
Join Date: Nov 2010
Device: Kobo Clara HD, iPad Pro 10", iPhone 15 Pro, Boox Note Max
Quote:
Originally Posted by NiLuJe View Post
We don't control CRe, we control *KOReader's* fork of CRe (what I linked to).

@poire-z often pulls upstream's CRe changes into our fork, and @virxkane often pulls our fork's changes into CRe's upstream .

So, when I say crengine, I mean our repo.

In which case, it needs to be bumped in koreader-base, and base needs to be bumped in koreader for it to show up in nigthlies.
So, should I submit my MR to the KOReader base repo then rather than the upstream repo?
twowheels is offline   Reply With Quote