View Single Post
Old 02-12-2021, 01:19 PM   #6
twowheels
Wizard
twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.twowheels ought to be getting tired of karma fortunes by now.
 
twowheels's Avatar
 
Posts: 1,854
Karma: 13432974
Join Date: Nov 2010
Device: Kobo Clara HD, iPad Pro 10", iPhone 15 Pro, Boox Note Max
Quote:
Originally Posted by NiLuJe View Post
Where *were* you looking, in both cases?

I mean, the clock formatting option for *CRe* was only added two weeks ago: https://github.com/koreader/crengine...11c151db03d95b, and I'm not sure it's even landed upstream yet, so it's currently only available in KOReader nightlies.
Oh, that makes more sense. I assumed that the flow was:

[change]->[crengine]->bump->[koreader]

Are you saying that there's cross pollination in both directions?

That's the exact block of code that I was trying to change, but to make it more consistent w/ the formatting in KOReader:

Code:
               int const raw_hour = bt->tm_hour > 12 ? bt->tm_hour % 12 : bt->tm_hour;
               int const hour = raw_hour?raw_hour:12;
               sprintf(str, "%d:%02d %s", hour, bt->tm_min, raw_hour<12?"AM":"PM");
The check-in comment was going to be:

Code:
    Improved 12 hour clock display
    
            The primary motivation of this improvement was to make the
            format more consistent with how 12 hour clocks are generally
            displayed, and consistent with how the other clocks are
            displayed when used within KOReader.
    
               * Made the midnight to 01:00 hour display 12 instead of 0
               * Added an AM/PM indicator

Last edited by twowheels; 02-12-2021 at 01:27 PM.
twowheels is offline   Reply With Quote