Quote:
Originally Posted by Atcold
We're talking about the buggy sorting, right? Can you expand a little (or link the diff)?
|
In that particular case, I was talking about how the My Clippings.txt file is read. With the move to Python 3, strings, unicode, UTF etc are handled differently. Add that some My Clippings.txt files seem to have different formatting and at least one has unicode BOM characters in a location I wouldn't have expected them (but sort of make sense), I have been going back and forth on where and how to decode the file. I changed it to as part of the open of the file, but, that parameter is not part of the Python 2 file open. I put out a beta with that, it broke the plugin under calibre 4.x. When I fixed it, I only did half the job. It probably worked for calibre 4.x, but, for calibre 5.x, it would not have found read the My Clippings.txt file properly and would not have found any annotations. Which is part of what was happening for you.
I haven't checked these changes in. I generally only do that when I make the actual release. It's a bit lazy of me, but, it is the way I work. If you want to look at the code, it is in "ParseKindleMyClippingsTxt.py", method "FromFileName" and the start of "FromFileName"
That looks good. But, it also says that you have only three books on the device that match to books in the library (have the green tick next to them). And the other five books that have annotations don't show as matched. Is that correct?
If so, you can fix this in the device view. Right-click (or whatever the equivalent on a MAC is) on an unmatched book and choose the "Match book to library" option. On the dialog that comes up, search for the book, select it and press OK to update the list. When finished matching them, right-click the device button and choose "Update cached metadata on device". This will update the metadata.calibre file on the device and calibre will match the book to the library in the future.
That's horrible. If you click the "Hide match status" it will use the default list colours and should be more readable. Someone did report this a few weeks ago and I said I wasn't interested. I thought the posted a version of the plugin that did something different with colour, but, it was removed before I had a chance to look at it. I don't know if it simply set colours that were better for dark-mode or did something else. I have to do something for colours in another plugin, so I might visit it here when I have done that.