Thread: Forma Lost Wikipedia access
View Single Post
Old 01-15-2021, 10:51 PM   #11
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,808
Karma: 7423683
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
I found the issue:

Code:
"https://word.m.wikipedia.org/wiki/Special:Search?search=en" => "Host word.m.wikipedia.org not found"
I mixed up the function parameter order while I did the final refactor...

Code:
extern "C" __attribute__((visibility("default"))) void _nm_menu_hook4(WebSearchMixinBase *_this, QString const& selection, QString const& locale) { 
     NM_LOG("hook4: %p %s %s", _this, qPrintable(selection), qPrintable(locale)); 
  
     nm_menu_item_t *it = _nm_menu_hook4_item(NULL); 
     if (!it) { 
         NM_LOG("No current menu item, continuing with default wikipedia search."); 
         WebSearchMixinBase_doWikipediaSearch(_this, locale, selection); 
         return; 
     }
I've released the fix in v0.5.1.

Quote:
Originally Posted by geek1011 View Post
NickelMenu v0.5.1

This release fixes a regression introduced in v0.5.0 which caused the built-in Wikipedia search to fail.

See the release on GitHub for more details.
geek1011 is offline   Reply With Quote