View Single Post
Old 01-08-2021, 10:20 AM   #57
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,893
Karma: 6120478
Join Date: Nov 2009
Device: many
Quote:
Originally Posted by wrCisco View Post
For the @import issue, I just saw two anomalies in the program output: the absence of TYPE and Data, as in
Code:
Information: 0
import: url(a_css.css)
Type: SEL_START  Data: @font-face
Type: PROPERTY  Data: font-family
and the missing space. I thought that it was not parsed properly, but I did not dig deeper than that, sorry if it wasn't clear.
Yes csstidy did not create tokens (or even token types) for @charset or @import and @namespace and so handle them directly in their own variables outside of the token list.

I think they did this as those can only come right at the top of the css file and so were special cased, but I do not really like that approach.

I have changed and modified CSSParser.cpp so much away from csstidy, that I will probably define and add in token types for those and put them into the css token list and remove the special cases.

I will work on the indentation issue but nested media queries are not css3 spec so the code will have to be modified to support them.

I am also going to add file offset starting positions for each token so that its output can be used to more easily modify the existing css file.

Thanks for all your testing and feedback!
KevinH is offline   Reply With Quote