View Single Post
Old 01-04-2021, 11:17 AM   #37
KevinH
Sigil Developer
KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.KevinH ought to be getting tired of karma fortunes by now.
 
Posts: 8,906
Karma: 6120478
Join Date: Nov 2009
Device: many
Okay I took a peek at the gumbo-query code and it silently threw strings (not exceptions) all throughout CParser that causes a sigabort not an actual sigsegfault.

So all of those unknown pseudo classes like ":lang(it)" (which BTW should/could have been converted to a simple attribute and value query) now result in throwing exceptions which are caught in CSelection find routine and a qDebug() message is printed and the result of the find is a CSelection with no valid GumboNode*

With these changes using our now more heavily modified Query should be a bit more robust.

I have pushed these changes to Sigil my own github site.
KevinH is offline   Reply With Quote