MobileRead Forums - View Single Post - "Delete unused stylesheet classes" problems with overloaded styles

wrCisco · 01-03-2021, 11:09 PM

I played a little with the Sigil/gumbo-query integration. Seems nice, but I got it to crash with a number of selectors:

Code:

p:nth-of-type(2n-1)
p:lang(it)
p.flush::first-letter
p:focus

I thought it could have a problem with pseudo classes with function-like syntax as

Code:

nth-of-type(2n-1)

but then I tried

Code:

:not(.someclass)

and not only it didn't cause a crash, but it also correctly found a match.
(and since ::first-letter and :focus will never match anything, it will be mostly a problem for the css parser to filter them out).

At the same time, just for the sake of it, I started experimenting with integrating the cssRemoveUnusedSelectors plugin in the Sigil reports tool. I succeeded in report back to the "CSS Classes" widget in the Reports dialog all the usages of the selectors (with the complete list of the number of matches per html file).
I'm not sure how best to proceed about the deletion functionality: I thought maybe keeping around the parsed css rules as PyObjectPtr when the selector usages are reported, and then passing it back to python to perform the deletion, would be a good approach (but how could I pass a PyObjectPtr to a python function through the embeddedpython::runInPython interface?). Or maybe it might be better to execute twice the parsing of the stylesheets - once for the reporting and once for the deletion - and to pass back and forth only the indices of the enumerated rules and selectors?

01-03-2021, 11:09 PM	#35
wrCisco Connoisseur Posts: 50 Karma: 605108 Join Date: Apr 2016 Device: none	I played a little with the Sigil/gumbo-query integration. Seems nice, but I got it to crash with a number of selectors: Code: p:nth-of-type(2n-1) p:lang(it) p.flush::first-letter p:focus I thought it could have a problem with pseudo classes with function-like syntax as Code: nth-of-type(2n-1) but then I tried Code: :not(.someclass) and not only it didn't cause a crash, but it also correctly found a match. (and since ::first-letter and :focus will never match anything, it will be mostly a problem for the css parser to filter them out). At the same time, just for the sake of it, I started experimenting with integrating the cssRemoveUnusedSelectors plugin in the Sigil reports tool. I succeeded in report back to the "CSS Classes" widget in the Reports dialog all the usages of the selectors (with the complete list of the number of matches per html file). I'm not sure how best to proceed about the deletion functionality: I thought maybe keeping around the parsed css rules as PyObjectPtr when the selector usages are reported, and then passing it back to python to perform the deletion, would be a good approach (but how could I pass a PyObjectPtr to a python function through the embeddedpython::runInPython interface?). Or maybe it might be better to execute twice the parsing of the stylesheets - once for the reporting and once for the deletion - and to pass back and forth only the indices of the enumerated rules and selectors?