View Single Post
Old 12-31-2020, 08:01 AM   #59
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,252
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by JSWolf View Post
Why a value of 116? When a value of 70 works?

Code:
# AuraHD/H2O/H2Ov2/GloHD/ClaraHD/LibraH2O
#- {Find: "footerMargin: 170;", Replace: "footerMargin:116;"}
It's set as a *default* value which, by my definition, should be based on logic rather than the spurious whims of one user who owns only a single Kobo model.

The lines of code you've referenced state clearly that this value will be used by all these models AuraHD/H2O/H2Ov2/GloHD/ClaraHD/LibraH2O. To avoid the potential "dogear bookmark problem" I've outlined previously, the *default* value needs to be big enough to accommodate the largest dogear icon in that set of models, namely the LibraH2O, whose dogear icon is 116x110px. The AuraHD/H2O/H2Ov2/GloHD/ClaraHD models all use a dogear icon sized 102x97px.

It looks like you didn't bother to read any of the Help notes I added to the patch where I attempted to explain this.
Code:
# Part 3. Increase the width of header/footer captions by reducing the width
#         of the pageturn tap zones in the footer's left/right corners
# N.B: 
#   The default Replace values below have been set larger than you might prefer.
#     This is to avoid the possibility of the "dogear" bookmark icon
#     in the top right corner being partially obscured by the header caption's white background.
#   See screenshot at following link for an example of what can sometimes happen 
#     if the new Replace value is too small.
#     https://www.mobileread.com/forums/sh...5&postcount=34
#   Feel free to reduce your custom Replace values if a wider caption area
#     is more important to you than "dogear" aesthetics. 
#     Alternatively, look at the Hint in Part 1 of this patch for a way to avoid
#     the "dogear" problem.
Pay particular attention to the last 4 lines.

I'd like to finish by saying that all the work I do on kobopatch is voluntary. Your obnoxious argumentative attitude regarding the addition of this new feature means I'm unlikely to ever respond positively to any future patch request you might make. In other words, find another mug.

@everyone,
If the Help notes in this (or any other) patch are not as clear/helpful as they could be I'm open to suggestions for improving them.
jackie_w is offline   Reply With Quote