View Single Post
Old 12-15-2020, 11:14 AM   #26
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,246
Karma: 16539642
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by geek1011 View Post
If @Semwize wants, I can add it to the main set of patches too.
Quote:
Originally Posted by Semwize View Post
@geek1011

Entities should not be multiplied unnecessarily.

IMHO, it's better to add lines to the "Custom new header / footer font" patch. And rename this patch, since there, besides the font, many things change
I agree with @Semwize. In fact I'd go further and say that this is an opportunity to combine all options for ReadingFooter into a single patch. I really don't like having multiple patches for a single nickel CSS stream. This would mean combining these patches:
  1. Reduce new header/footer height
  2. Custom new header/footer font
  3. this new beta feature to expand the caption width by reducing L/R pageturn tap zone width
Obviously, this may make the new mega-patch appear more complex. I know people can be resistant to change.

Incidentally, if I add the beta item 3 to standard nickel.yaml I don't think I can use @Semwize's new values as the default Replace values. This is because they are too small in some circumstances. If a dogear bookmark is set at top right, then it's possible for the white background of the caption to partially overlay the left edge of the dogear icon - which is ugly. My defaults would be to make the Replace values exactly the same width as each model's dogear icon so that overlaying is not possible.

Of course, individual users will still be able to customise their own values as small as they like if they don't care about the aesthetics.

Thoughts???

Last edited by jackie_w; 12-15-2020 at 11:16 AM.
jackie_w is offline   Reply With Quote