View Single Post
Old 11-30-2020, 03:16 AM   #536
davidfor
Grand Sorcerer
davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.davidfor ought to be getting tired of karma fortunes by now.
 
Posts: 24,905
Karma: 47303824
Join Date: Jul 2011
Location: Sydney, Australia
Device: Kobo:Touch,Glo, AuraH2O, GloHD,AuraONE, ClaraHD, Libra H2O; tolinoepos
Quote:
Originally Posted by queensacrifice View Post
For this, in the line in __init__.py that reads
Code:
if identifier_name in ('amazon', 'asin') or identifier_name.startswith('amazon_'):
I added mobi-asin to the list, so that the line reads
Code:
if identifier_name in ('amazon', 'asin', 'mobi-asin') or identifier_name.startswith('amazon_'):
That makes sense. I have added it in the attached beta. But, it might not solve @Freakeao problem.

Firstly, the tooltip for the "Get ASIN for kindle editions" option is:

Quote:
When this option is checked, in cases where Goodreads has an ASIN listed instead of an ISBN, the ASIN is retrieved. This is useful for books that already have the specific Goodreads identifier of a kindle editon.
That doesn't say to use the ASIN, but, if the book that is found has am ASIN, to get it. The ASIN will be put into the amazon identifier. And will replace any existing amazon identifier. The plugin will use the Goodreads ID and then the ISBN. If these do not find a book, the Amazon identifiers will be tried. For a book from Amazon just added, I think it will just have one of the Amazon identifiers. But, if it has an ISBN, it will get that edition.
Attached Files
File Type: zip Goodreads-beta.zip (24.4 KB, 221 views)
davidfor is offline   Reply With Quote